Replace frigate with helm-docs #160
Conversation
There was a problem hiding this comment.
In principal I am good with this change .. however.. the rendered output does not show and description anymore.. I am hoping we can somehow make the docs for all the values more useful. Can we somehow fix this?
In fact I am contemplating adding a website similar to how we just got it added in the Trino Gateway repo .. so we can write some useful docs for the charts that go beyond what we have in the Trino docs themselves.
|
Also .. if helm-docs is good .. we want to look at adding its usage for the Trino Gateway chart in the trino-gateway repo. |
nineinchnick
force-pushed
the
update-ci
branch
4 times, most recently
from
cb4071e
to
d570154
Compare
|
@mosabua I've used a custom template to print all values as a definition list instead of a table. I included those large examples that wouldn't fit in the table well. I also filled in most descriptions with links to Kubernetes and Trino documentation, where relevant. Please review. |
nineinchnick
force-pushed
the
update-ci
branch
2 times, most recently
from
dd2c8f4
to
79fbcc0
Compare
Avoid trailing comments, move them to a separate line
Use
pre-commitso developers can use a git hook to regenerate docs.I replaced
frigatewithhelm-docsbecause frigate's pre-commit hook requirescondato install it.helm-docsrun from a Docker container.Also update all GitHub actions and enable Dependabot.